fix(compass): add support for expanded#7987
Conversation
|
Preview: https://pf-pr-7987.surge.sh A11y report: https://pf-pr-7987-a11y.surge.sh |
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Question/potential change below. Also do we have it tracked to have a demo showing how one could go about handling the expanding functionality in React, or can that be handled by any generic followup for cleaning up demos/examples?
| {{#unless compass-footer--IsCollapsed}} | ||
| pf-m-expanded | ||
| {{/unless}} |
There was a problem hiding this comment.
For these 3 components, do we want to just add inert as well when it's collapsed to be doubly sure content can't be accessed?
srambach
left a comment
srambach
left a comment
There was a problem hiding this comment.
Does rearranging to put the message bar into the main content mean that it will need to handle expanding, or if that's desired the user will have to use the footer?
| translate: -100%; | ||
| } | ||
|
|
||
| &.pf-m-end { | ||
| grid-area: sidebar-end; | ||
| translate: 100%; |
There was a problem hiding this comment.
You'll need an RTL value of the inverse so it slides the correct direction
There was a problem hiding this comment.
**shakes fist angrily** darn you RTL, you have foiled me once again!
I'll open a separate PR to smooth out the animation per @lboehling's comment this morning |
|
🎉 This PR is included in version 6.5.0-prerelease.26 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 participants
fixes #7983
.pf-m-expandedon any of the header/sidebars/footer to have it show/hide