fix(compass): restructure navigation to include home and search#7985
Merged
Conversation
Collaborator
|
Preview: https://pf-pr-7985.surge.sh A11y report: https://pf-pr-7985-a11y.surge.sh |
mcoker
reviewed
Nov 11, 2025
mcoker
left a comment
mcoker
left a comment
Contributor
There was a problem hiding this comment.
- Left a comment about separating the panel padding vars
- Also would you mind taking the inset variation off of the tabs and adding a
lgspacer as left/right padding to__nav-main? That's a little less space and it still looks ok. - And attaching the home and search icons. I grabbed them from figma and edited them without testing to make sure they work. They should just need width/height of 1em, class
.pf-v6-svgand any fill colors set tocurrentcolor
| } | ||
|
|
||
| .#{$compass}__nav { | ||
| --#{$compass}__panel--Padding: 0 var(--#{$compass}__nav--Padding); // assumes there are tabs pushing the height enough not to need block padding on the home/search buttons |
Contributor
There was a problem hiding this comment.
We should probably separate __panel--Padding into the 4 sides. Do you mind doing that in this PR? The only other place you'd need to update the use of __panel--Padding is the sidebar padding here - https://github.com/srambach/patternfly/blob/432fb30ea563b5f069002910420b37e57e263d85/src/patternfly/components/Compass/compass.scss#L98.
Contributor
|
Also looks like you need to rebase. Probably just need to remove |
srambach
force-pushed
the
7930-compass-nav-restructure
branch
from
432fb30 to
298fb3a
Compare
Collaborator
|
🎉 This PR is included in version 6.5.0-prerelease.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7930
This changes the nav structure to be
__nav __panel __nav-content __nav-home __nav-main __nav-searchNOTE: it sets the block padding of the nav element to 0 because tabs push it too tall and then the pill ends don't match the round buttons. Technically I think it's still a pixel or two off...input welcome.
ALSO: I didn't add in a home or search icon but can do that if desired and someone provides the svg code for them.