Skip to content

Fix 0.6.2 compatibility test shutdown #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 1 commit into from
Jun 24, 2026
+5 −1
Merged

Fix 0.6.2 compatibility test shutdown #947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/integration_tests_rust.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2580,7 +2580,11 @@ async fn build_0_6_2_node(
assert!(balance > 0);
let node_id = node_old.node_id();

node_old.stop().unwrap();
// Workaround necessary as v0.6.2's runtime wasn't dropsafe in a tokio context.
tokio::task::block_in_place(move || {

@joostjager joostjager Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vss_no_auth integration test uses spawn_blocking for a similar code block.

node_old.stop().unwrap();
drop(node_old);
});

(balance, node_id)
}
Expand Down
Loading