Fix 0.6.2 compatibility test shutdown#947
Conversation
Stop and drop the old compatibility node from a blocking region. This avoids a Tokio runtime-drop panic in the async test. Co-Authored-By: HAL 9000
|
👋 Thanks for assigning @joostjager as a reviewer! |
|
AI analysis regarding why now: What is happening: v0.6.2's The subtle part is the |
|
|
||
| node_old.stop().unwrap(); | ||
| // Workaround necessary as v0.6.2's runtime wasn't dropsafe in a tokio context. | ||
| tokio::task::block_in_place(move || { |
There was a problem hiding this comment.
The vss_no_auth integration test uses spawn_blocking for a similar code block.
Stop and drop the old compatibility node from a blocking region.
This avoids a Tokio runtime-drop panic in the async test.
Honestly not quite sure what changed that this only surfaces now that CI is back (likely an unrelated refactoring while CI was gone is to blame). But we need to fix it so CI finally is green again.