Skip to content

fix(react-query-devtool): correct the noop entry for cjs#3893

Merged
TkDodo merged 1 commit into
TanStack:mainfrom
songkeys:fix-cjs-noop-entry
Jul 21, 2022
Merged

fix(react-query-devtool): correct the noop entry for cjs#3893
TkDodo merged 1 commit into
TanStack:mainfrom
songkeys:fix-cjs-noop-entry

Conversation

@songkeys

@songkeys songkeys commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

#3884 (comment)

Sorry about the previous PR.

The current build system is actually somehow messy. We might need to tidy it up once v4 is stable.

@TkDodo

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d3cbf78:

Sandbox Source
@tanstack/query-example-react-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration

@TkDodo

TkDodo commented Jul 21, 2022

Copy link
Copy Markdown
Collaborator

fully agree, thank you 🙏

we can track improvements here:

@TkDodo TkDodo merged commit 1c4e005 into TanStack:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants