Skip to content

fix(react-query-devtools): support cjs in noop build#3884

Merged
TkDodo merged 2 commits into
TanStack:mainfrom
songkeys:fix-cjs-noop
Jul 20, 2022
Merged

fix(react-query-devtools): support cjs in noop build#3884
TkDodo merged 2 commits into
TanStack:mainfrom
songkeys:fix-cjs-noop

Conversation

@songkeys

Copy link
Copy Markdown
Contributor

Just noticed that someone also made a PR #3883 . But we should export the noop version.

@vercel

vercel Bot commented Jul 20, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
query ❌ Failed (Inspect) Jul 20, 2022 at 4:54PM (UTC)

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9bd505f:

Sandbox Source
@tanstack/query-example-react-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration

@TkDodo

TkDodo commented Jul 20, 2022

Copy link
Copy Markdown
Collaborator

Do we need your PR, the other PR, or both?

@TkDodo

TkDodo commented Jul 20, 2022

Copy link
Copy Markdown
Collaborator

Your PR actually looks more complete, thank you 🙏

@songkeys

Copy link
Copy Markdown
Contributor Author

Yes. The other PR pointed out the issue but doesn't export for noop actually. This PR should fix them all.

@TkDodo

TkDodo commented Jul 20, 2022

Copy link
Copy Markdown
Collaborator

Thank you very much 🙇‍♂️

@TkDodo

TkDodo commented Jul 21, 2022

Copy link
Copy Markdown
Collaborator

@songkeys could it be that we point to the wrong direction for the default require exports. It points towards:

"require": "./build/cjs/packages/react-query-devtools/src/noop.js",

but looking at the build directory when I create a build locally, noop.js is in :

build/cjs/noop.js

so it's not inside the src directory...

@songkeys

Copy link
Copy Markdown
Contributor Author

@TkDodo Oops. I'm sorry about this. You are right. Is it a fix yet? Or do you want me to submit another PR?

@TkDodo

TkDodo commented Jul 21, 2022

Copy link
Copy Markdown
Collaborator

another PR would be great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants