fix: prevent nanosecond overflow in OTLP timestamps#3973
Conversation
Multiply after BigInt conversion to avoid IEEE 754 precision loss. Affects 4 locations where epoch-ms * 1e6 exceeds Number.MAX_SAFE_INTEGER. Fixes triggerdotdev#3292
|
|
Hi @deepshekhardas, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| ## What | ||
|
|
||
| This PR updates route components to use the animated Resizable panel pattern: | ||
| - Converts conditionally-rendered panels to always-mounted animated panels with `collapsible`, `collapsed`, and `collapseAnimation` props | ||
| - Adds `useFrozenValue` hook usage to keep last selected item visible during panel collapse animation | ||
| - Minor UI polish on logs, runs, schedules, waitpoints pages | ||
|
|
||
| ## Changes | ||
|
|
||
| - **Resizable.tsx** — skipped (main already has these exports) | ||
| - **Route files** (logs, runs, schedules, batches, etc.) — convert panel pattern, add `useFrozenValue` | ||
| - **LogsTable, TreeView, GitMetadata** — minor improvements | ||
|
|
||
| ## Manual resolution | ||
|
|
||
| Merge had 3 conflicts: | ||
| - `Resizable.tsx`: kept main's version (already has animated panel exports with Firefox workarounds) | ||
| - `logs/route.tsx` line 419: removed pointless `?? undefined` (PR's cleaner version) | ||
| - `runs.$runParam/route.tsx`: kept `panel-run-parent-v3` autosaveId, removed `?? undefined` | ||
|
|
||
| ## Original PRs | ||
| - Original: #3267 | ||
| - This replaces: #3319 | ||
|
|
||
| Co-authored-by: James Ritchie <james@trigger.dev> |
There was a problem hiding this comment.
🟡 Accidentally committed pr-body-*.txt files to the repository root
Two unrelated files (pr-body-3321.txt and pr-body-3322.txt) are included in this PR's diff. These are PR description drafts for other PRs (#3321 and #3322) and have no relation to the BigInt precision fix. They will pollute the repository root if merged.
Prompt for agents
Delete both pr-body-3321.txt and pr-body-3322.txt from the repository. These are PR description drafts for unrelated PRs that were accidentally committed alongside the BigInt precision fix. They should be removed from the commit before merging (e.g. via git rm pr-body-3321.txt pr-body-3322.txt).
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Multiply after BigInt conversion to avoid IEEE 754 precision loss.
Affects 4 locations where epoch-ms * 1e6 exceeds Number.MAX_SAFE_INTEGER.
Fixes #3292