Skip to content

Fix broken install Makefile target, update README#214

Merged
mclasmeier merged 4 commits into
mainfrom
mc/fix-install-target
Jun 22, 2026
Merged

Fix broken install Makefile target, update README#214
mclasmeier merged 4 commits into
mainfrom
mc/fix-install-target

Conversation

@mclasmeier

@mclasmeier mclasmeier commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator
  • Fixes the install Makefile target (it was broken before).
  • Mention it in the README.
  • Reorganize the install instructions in the README
  • Update some parts of the README: Use --tag/-t instead of MAIN_IMAGE_TAG, don't reference outdated ACS versions.

Summary by CodeRabbit

  • Documentation

    • Updated installation instructions with multiple deployment paths including local development and CI environments
    • Updated deployment examples from version 4.9.2 to 4.11.0
    • Added native executable deployment guidance with component selection options
  • Chores

    • Improved build system binary installation configuration

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@mclasmeier, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 58 minutes and 9 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: 15584105-3570-45be-855c-092f3f1ec2c2

📥 Commits

Reviewing files that changed from the base of the PR and between fda0eb1 and 22c1a2c.

📒 Files selected for processing (1)
  • README.md
📝 Walkthrough

Walkthrough

The Makefile install target is rewritten to derive GOPATH from go env GOPATH, compute an explicit INSTALLED_BINARY path, and build ./cmd directly into that path instead of using go install. The README expands installation instructions into subsections and updates example deployment tags from 4.9.2 to 4.11.0.

Changes

Install target fix and README update

Layer / File(s) Summary
Makefile install target rewrite
Makefile
Adds GOPATH (defaulting to go env GOPATH) and INSTALLED_BINARY ($(GOPATH)/bin/$(BINARY_NAME)) variables; rewrites install target to mkdir -p the destination and go build -o $(INSTALLED_BINARY) from ./cmd with existing LDFLAGS, replacing go install.
README installation docs and version tags
README.md
Splits the installation section into subsections for local dev (latest release and source build), CI, and container image; rewrites Option 2 quick-start as "Deploying using native executable" with ./roxie deploy -t 4.11.0; bumps all example deployment tags from 4.9.2 to 4.11.0 including multi-cluster steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • stackrox/roxie#207: Updates README.md installation and quick-start documentation with GitHub-release and container-based install examples, directly overlapping with this PR's README changes.

Poem

🐇 Hippity-hop, no go install today,
I build the binary my own special way!
GOPATH resolved, the destination is clear,
mkdir -p first, then drop the files here.
The README got shinier, version bumped too —
4.11.0 now, and the docs feel brand new! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main changes: fixing the broken install Makefile target and updating the README documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mc/fix-install-target

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mclasmeier mclasmeier changed the title Mc/fix install target Fix broken install Makefile target, update README Jun 22, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Line 101: The comment referencing the `MAIN_IMAGE_TAG` environment variable is
outdated since the example above now uses the `-t` flag approach (deploy -t
4.11.0). Update the line that says "Specify the `MAIN_IMAGE_TAG` as desired" to
reflect the current `-t` flag method, or remove it entirely if the approach is
self-evident from the example above.
- Line 99: The README documentation examples uniformly use version 4.11.0, but
the codebase default for `defaultMainImageTag` in internal/helpers/tag.go is set
to 4.9.2, creating a mismatch. Update the `defaultMainImageTag` constant to
4.11.0 to align the code default with the documented examples. This ensures
consistency so users who follow README examples or omit the version flag receive
the same version as the documentation shows.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: 64d6dac7-41f4-4681-a146-d2ebedab86f8

📥 Commits

Reviewing files that changed from the base of the PR and between b91d393 and fda0eb1.

📒 Files selected for processing (2)
  • Makefile
  • README.md

Comment thread README.md
Comment thread README.md Outdated

@dcaravel dcaravel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mclasmeier mclasmeier merged commit 6887804 into main Jun 22, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants