feat(operator): implement basic fact operator#857
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
At this point the operator is a PoC, meant only as a small experiment to see if it is even possible to implement. TODO: * Expose more configuration options. * Implement some sort of test that will ensure the operator works and deploys fact correctly.
This requires some refactoring to re-use the FactConfig struct as part of the CRD spec for fact. We also make all configuration apply through a config map, which means we can hotreload the configuration as required. Still needs more testing, but so far it looks good.
cfbdf99 to
cf00347
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
==========================================
+ Coverage 27.96% 29.16% +1.20%
==========================================
Files 21 25 +4
Lines 2596 2866 +270
Branches 2596 2866 +270
==========================================
+ Hits 726 836 +110
- Misses 1867 2027 +160
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
6429ba3 to
cf00347
Compare
Description
Still a WIP and more of an experiment than production ready operator.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.