Invalid request headers due to machine name

[StevenJohnston]

On macOS my default machine name was Steven’s-MacBook-Pro This was causing split.io to emit SDK_READY_TIMED_OUT. I assume due to the ’ in the name.

What did not work was:

const config: INodeSettings = {
      ...
      sync: {
        requestOptions: {
          getHeaderOverrides: (context) => {
            context.headers.SplitSDKMachineName = 'StevensMacBookPro';
            return context.headers;
          },
        },
      },
      ...
}

What did work was:

• changing my machines name via sudo scutil --set HostName "stevensmacbookpro"

[IngaAlma]

Hi Steven,
In the example above, you've entered the machine name without ':
context.headers.SplitSDKMachineName = 'StevensMacBookPro';
Does this fail?

I was also able to run this configuration with no issues:
requestOptions: {
getHeaderOverrides: (context) => {
// Add a custom header
context.headers.SplitSDKMachineName = "Steven's-Mac'Book-Pro";

                    // Return modified headers
                    return context.headers;
                }
            }, 

Best,
Inga

[StevenJohnston]

In my example getHeaderOverrides was not modifying my SplitSDKMachineName header.

I think our quotes are differing Steven’s-MacBook-Pro ’ as U+2019 and Steven's-Mac'Book-Pro ' as U+0027.

Since getHeaderOverrides was not modifying the header, i think the only way to test is by altering your hostname on your machine as I did. macOS via sudo scutil --set HostName "Steven’s-MacBook-Pro"

[EmilianoSanchez]

Hi @StevenJohnston ,

Thanks for sharing your issue. I’ve checked on my side and confirmed that this is a bug in the SDK. It should eliminate or sanitize characters not ISO-8859-1, like ’, from header values because the Node.js http/https API and Web fetch API throw an exception.

We’ll address this in the next release, but unfortunately, we don’t have an ETA yet.

Additionally, the SplitSDKMachineName header is one of the SDK’s special headers that cannot be overwritten using the getHeaderOverrides configuration option. So, for now, the only workaround I see is to update your hostname as you suggested.

I will keep the issue open, and close it when we fix the problem.

[EmilianoSanchez]

Actually, @StevenJohnston , there is another workaround: you can set the core.IPAddressesEnabled configuration option to false, so that the SplitSDKMachineIP and SplitSDKMachineName headers are not sent.

Example:

const config: INodeSettings = {
      core: {
        ...
        IPAddressesEnabled: false
      },
      ...
}

Reference here.

[EmilianoSanchez]

Hi @StevenJohnston ,

I’m closing this issue for now, as we’ve just released JavaScript SDK v11.0.3, which includes a fix. Try this new version on your side.

Thank you