improvement(search): align cmd+k action icons + highlight with the design system#5114
Conversation
…sign system - Each Actions verb now uses the exact icon from its real location: Fit to view -> Scan (workflow-controls), Copy workflow link -> Duplicate (nav context menu), Invite teammates -> User (settings teammates nav). Run/Create/Import already matched. - Remove the Toggle theme action and its now-dead useTheme wiring. - Matched-text highlight now uses the design-system search tokens (--highlight-match-bg / --highlight-match-text), matching the SearchHighlight component used in knowledge-base and code search, instead of an ad-hoc font-semibold.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Fuzzy-match labels in Reviewed by Cursor Bugbot for commit 58f90ed. Configure here. |
Drop the colored background highlight in favor of the design system's standard emphasis weight (font-medium, used by Button/Label/Input/Table). Lighter than the previous semibold and avoids a background, keeping the palette's clean, undecorated text style.
|
@greptile |
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 58f90ed. Configure here.
| {buildSegments(text, positions).map((segment, index) => | ||
| segment.hit ? ( | ||
| <span key={index} className='font-semibold text-[var(--text-body)]'> | ||
| <span key={index} className='font-medium'> |
There was a problem hiding this comment.
Match highlight missing design tokens
Low Severity
HighlightedText marks fuzzy matches with only font-medium, while knowledge-base and code search use SearchHighlight’s bg-[var(--highlight-match-bg)] and text-[var(--highlight-match-text)] with no extra weight. Cmd+k search hits therefore look different from the rest of search UI and from what this change describes.
Reviewed by Cursor Bugbot for commit 58f90ed. Configure here.
Greptile SummaryThis PR polishes the cmd+k command palette: it replaces three action icons with ones that match their real-UI counterparts, removes the "Toggle theme" action and its
Confidence Score: 3/5Merging is low-risk from a functional standpoint — no data mutations or auth paths are touched — but the fuzzy-match highlight will appear as a barely-noticeable weight change rather than the colour-backed highlight that was the stated goal of the PR. The highlight change in
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[cmd+k opens SearchModal] --> B[User types query]
B --> C[HighlightedText renders matched chars]
C --> D{segment.hit?}
D -- yes --> E["span.font-medium (PR: was font-semibold)"]
D -- no --> F[plain span]
B --> G[filteredActions computed]
G --> H{context matches page?}
H -- workflow --> I["fit-to-view → Scan from lucide-react"]
H -- workflow --> J["copy-workflow-url → Duplicate from emcn"]
H -- global --> K["invite-teammates → User from emcn"]
H -- global --> L["create/folder/import (unchanged)"]
M["toggle-theme action REMOVED"] -.->|"useTheme dependency dropped"| N["next-themes no longer used here"]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[cmd+k opens SearchModal] --> B[User types query]
B --> C[HighlightedText renders matched chars]
C --> D{segment.hit?}
D -- yes --> E["span.font-medium (PR: was font-semibold)"]
D -- no --> F[plain span]
B --> G[filteredActions computed]
G --> H{context matches page?}
H -- workflow --> I["fit-to-view → Scan from lucide-react"]
H -- workflow --> J["copy-workflow-url → Duplicate from emcn"]
H -- global --> K["invite-teammates → User from emcn"]
H -- global --> L["create/folder/import (unchanged)"]
M["toggle-theme action REMOVED"] -.->|"useTheme dependency dropped"| N["next-themes no longer used here"]
Reviews (1): Last reviewed commit: "improvement(search): use font-medium for..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
1 participant
Summary
Scan(workflow-controls), Copy workflow link →Duplicate(nav context menu), Invite teammates →User(settings teammates nav). Run/Create/Create folder/Import already matched their real spots.useTheme/next-themeswiring.--highlight-match-bg/--highlight-match-text— the same treatment as theSearchHighlightcomponent used in knowledge-base and code search — instead of an ad-hocfont-semibold. (font-semiboldwasn't a design convention; the search-match precedent is color + background, no weight.)Type of Change
Testing
Checklist