-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix(deployed-chat): made the chat mobile friendly #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,8 @@ import { Send, Square } from 'lucide-react' | |
| import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip' | ||
| import { VoiceInput } from './voice-input' | ||
|
|
||
| const PLACEHOLDER = 'Enter a message or click the mic to speak' | ||
| const PLACEHOLDER_MOBILE = 'Enter a message' | ||
| const PLACEHOLDER_DESKTOP = 'Enter a message or click the mic to speak' | ||
| const MAX_TEXTAREA_HEIGHT = 160 // Max height in pixels (e.g., for about 4-5 lines) | ||
|
|
||
| const containerVariants = { | ||
|
|
@@ -195,31 +196,50 @@ export const ChatInput: React.FC<{ | |
|
|
||
| <div className='pointer-events-none absolute top-0 left-0 flex h-full w-full items-center'> | ||
| {!isActive && !inputValue && ( | ||
| <div | ||
| className='-translate-y-1/2 absolute top-1/2 left-3 select-none text-gray-400' | ||
| style={{ | ||
| whiteSpace: 'nowrap', | ||
| zIndex: 0, | ||
| background: | ||
| 'linear-gradient(90deg, rgba(150,150,150,0.2) 0%, rgba(150,150,150,0.8) 50%, rgba(150,150,150,0.2) 100%)', | ||
| backgroundSize: '200% 100%', | ||
| WebkitBackgroundClip: 'text', | ||
| WebkitTextFillColor: 'transparent', | ||
| animation: 'shimmer 10s infinite linear', | ||
| }} | ||
| > | ||
| {PLACEHOLDER} | ||
| <style jsx global>{` | ||
| @keyframes shimmer { | ||
| 0% { | ||
| background-position: 200% 0; | ||
| <> | ||
| {/* Mobile placeholder */} | ||
| <div | ||
| className='-translate-y-1/2 absolute top-1/2 left-3 select-none text-gray-400 md:hidden' | ||
| style={{ | ||
| whiteSpace: 'nowrap', | ||
| zIndex: 0, | ||
| background: | ||
| 'linear-gradient(90deg, rgba(150,150,150,0.2) 0%, rgba(150,150,150,0.8) 50%, rgba(150,150,150,0.2) 100%)', | ||
| backgroundSize: '200% 100%', | ||
| WebkitBackgroundClip: 'text', | ||
| WebkitTextFillColor: 'transparent', | ||
| animation: 'shimmer 10s infinite linear', | ||
| }} | ||
| > | ||
| {PLACEHOLDER_MOBILE} | ||
| </div> | ||
| {/* Desktop placeholder */} | ||
| <div | ||
| className='-translate-y-1/2 absolute top-1/2 left-3 hidden select-none text-gray-400 md:block' | ||
| style={{ | ||
| whiteSpace: 'nowrap', | ||
| zIndex: 0, | ||
| background: | ||
| 'linear-gradient(90deg, rgba(150,150,150,0.2) 0%, rgba(150,150,150,0.8) 50%, rgba(150,150,150,0.2) 100%)', | ||
| backgroundSize: '200% 100%', | ||
| WebkitBackgroundClip: 'text', | ||
| WebkitTextFillColor: 'transparent', | ||
| animation: 'shimmer 10s infinite linear', | ||
| }} | ||
| > | ||
| {PLACEHOLDER_DESKTOP} | ||
| <style jsx global>{` | ||
| @keyframes shimmer { | ||
| 0% { | ||
| background-position: 200% 0; | ||
| } | ||
| 100% { | ||
| background-position: -200% 0; | ||
| } | ||
| } | ||
| 100% { | ||
| background-position: -200% 0; | ||
| } | ||
| } | ||
| `}</style> | ||
| </div> | ||
| `}</style> | ||
| </div> | ||
|
Comment on lines
+231
to
+241
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: consider moving keyframes animation to a separate CSS file to prevent duplication across multiple instances |
||
| </> | ||
| )} | ||
| </div> | ||
| </div> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: gradient background styles are duplicated between mobile and desktop placeholders - consider extracting to a shared style object or CSS class