fix: /etc/environment keys with underscores being dropped#391
Merged
Conversation
The key validation only accepted alphanumeric characters, but pam_env (whose parsing this file explicitly ports) also allows underscores — and almost every real /etc/environment entry (JAVA_HOME, LC_ALL, HTTP_PROXY, XDG_DATA_DIRS, ...) contains one. All such variables were silently missing from shpool sessions while normal ssh/console logins got them. Match pam_env: ascii alphanumerics plus underscore.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Policy Ack
✅ AI Policy
This PR was:
✅ completely vibe coded
Found by Claude Fable 5.
Description
The key validation only accepted alphanumeric characters, but pam_env (whose parsing this file explicitly ports) also allows underscores — and almost every real /etc/environment entry (JAVA_HOME, LC_ALL, HTTP_PROXY, XDG_DATA_DIRS, ...) contains one. All such variables were silently missing from shpool sessions while normal ssh/console logins got them. Match pam_env: ascii alphanumerics plus underscore.
This is hypothetical for me - I don't think I've personally run into issues as a result of this - but it does seem like a valid concern; environmental variable keys do often contain underscores and that's explicitly supported in /etc/environment per the pam_env source. I checked on my Linux work box and indeed bash running inside shpool doesn't have any of the underscored environment variables, whereas bash under SSH does.