Skip to content
This repository was archived by the owner on Apr 15, 2026. It is now read-only.

Prepare for a 1.0.0 release#8

Merged
knu merged 4 commits into
masterfrom
prepare-release
Dec 21, 2020
Merged

Prepare for a 1.0.0 release#8
knu merged 4 commits into
masterfrom
prepare-release

Conversation

@knu

@knu knu commented Dec 21, 2020

Copy link
Copy Markdown
Member

I'm going to release 1.0.0 soon so it can be bundled with Ruby 3.0.

@knu knu requested a review from marcandre December 21, 2020 03:15

@marcandre marcandre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
One question though: is there a solution for anyone using SortedSet?

@knu

knu commented Dec 21, 2020

Copy link
Copy Markdown
Member Author

I’m thinking of releasing a sorted_set gem after working on this!

@marcandre

Copy link
Copy Markdown
Member

I’m thinking of releasing a sorted_set gem after working on this!

Good. Do you want help?

It could be nice to use autoload to display a better error message in case someone uses SortedSet. Would you like a PR for this?

@knu

knu commented Dec 21, 2020

Copy link
Copy Markdown
Member Author

Good. Do you want help?

Thanks! I'll create a first draft and ask you for a review.

It could be nice to use autoload to display a better error message in case someone uses SortedSet. Would you like a PR for this?

That sounds great. It's worth a try!

@knu knu merged commit 0a55790 into master Dec 21, 2020
@knu knu deleted the prepare-release branch December 21, 2020 05:55
@knu

knu commented Dec 22, 2020

Copy link
Copy Markdown
Member Author

I just released a sorted_set gem: https://rubygems.org/gems/sorted_set

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants