Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/cgi/core.rb
Original file line number Diff line number Diff line change
Expand Up @@ -838,13 +838,16 @@ def read_from_cmdline
# Handles multipart forms (in particular, forms that involve file uploads).
# Reads query parameters in the @params field, and cookies into @cookies.
def initialize_query()
content_length = env_table['CONTENT_LENGTH']
content_length = nil if content_length == ''
if ("POST" == env_table['REQUEST_METHOD']) and
%r|\Amultipart/form-data.*boundary=\"?([^\";,]+)\"?| =~ env_table['CONTENT_TYPE']
current_max_multipart_length = @max_multipart_length.respond_to?(:call) ? @max_multipart_length.call : @max_multipart_length
raise StandardError.new("too large multipart data.") if env_table['CONTENT_LENGTH'].to_i > current_max_multipart_length
raise StandardError.new("no content length for multipart data.") if content_length.nil?
boundary = $1.dup
@multipart = true
@params = read_multipart(boundary, Integer(env_table['CONTENT_LENGTH']))
@params = read_multipart(boundary, Integer(content_length))
else
@multipart = false
@params = CGI.parse(
Expand All @@ -857,7 +860,11 @@ def initialize_query()
end
when "POST"
stdinput.binmode if defined? stdinput.binmode
stdinput.read(Integer(env_table['CONTENT_LENGTH'])) or ''
if content_length.nil?
stdinput.read or ''
else
stdinput.read(Integer(content_length)) or ''
end
else
read_from_cmdline
end.dup.force_encoding(@accept_charset)
Expand Down
27 changes: 27 additions & 0 deletions test/cgi/test_cgi_core.rb
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,33 @@ def test_cgi_core_params_POST
$stdin = STDIN
end

def test_cgi_core_params_POST_without_content_length
update_env(
'REQUEST_METHOD' => 'POST',
'CONTENT_TYPE' => 'application/x-www-form-urlencoded',
)
$stdin = StringIO.new
cgi = nil
assert_nothing_raised { cgi = CGI.new }
assert_equal({}, cgi.params)
ensure
$stdin = STDIN
end

def test_cgi_core_params_POST_empty_content_length
update_env(
'REQUEST_METHOD' => 'POST',
'CONTENT_TYPE' => 'application/x-www-form-urlencoded',
'CONTENT_LENGTH' => '',
)
$stdin = StringIO.new
cgi = nil
assert_nothing_raised { cgi = CGI.new }
assert_equal({}, cgi.params)
ensure
$stdin = STDIN
end

def test_cgi_core_params_encoding_check
query_str = 'str=%BE%BE%B9%BE'
update_env(
Expand Down
Loading