[DOC] Fix examples in accept_charset and http_header docs#125
Merged
Conversation
CGI.accept_charset is initialized to Encoding::UTF_8 by the cgi/escape extension when 'cgi' is required, so the inspect examples should show #<Encoding:UTF-8>, not the string "UTF-8". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The +content_type+ paragraph said "its default value" while its example shows the given value being used, and the 'length' key was missing "to". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the recently merged documentation work in #95, #97, and #98.
The accept_charset examples showed the default value as the string "UTF-8". Requiring 'cgi' loads the cgi/escape extension, which initializes @@accept_charset to Encoding::UTF_8, so the real inspect output is #Encoding:UTF-8. The examples now reflect that.
The http_header documentation said the string content_type argument uses "its default value" while its own example passes and prints text/xml, so it now says the given value is used. The 'length' key description was also missing "to".