fix: normalize globby paths in deadLinkChecker for Windows compatibility#8481
Open
Umesh-369 wants to merge 1 commit into
Open
fix: normalize globby paths in deadLinkChecker for Windows compatibility#8481Umesh-369 wants to merge 1 commit into
Umesh-369 wants to merge 1 commit into
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a cross-platform compatibility bug in the
scripts/deadLinkChecker.jsscript.On Windows machines, running
yarn deadlinksresults in hundreds of false-positive anchor errors (e.g.,556 dead links out of 1822 total links). This happens becauseglobby.syncreturns POSIX-style paths (using forward slashes/), while Node's nativepath.join(used during validation/lookup) returns Windows-style paths (using backslashes\). As a result, the lookup keys inanchorMapdo not match, causing all anchor check lookups to fail.Solution
In
scripts/deadLinkChecker.js, inside thegetMarkdownFiles()function, we mappath.normalize(p)onto the array returned byglobby.sync():