Skip to content

Update default .gitignore to work with fastlane setups in sub-folders#13261

Closed
KrauseFx wants to merge 1 commit into
react:masterfrom
KrauseFx:patch-1
Closed

Update default .gitignore to work with fastlane setups in sub-folders#13261
KrauseFx wants to merge 1 commit into
react:masterfrom
KrauseFx:patch-1

Conversation

@KrauseFx

@KrauseFx KrauseFx commented Apr 3, 2017

Copy link
Copy Markdown
Contributor

Currently the default way to setup fastlane for ReactNative projects is to set it up in the ios or android subfolder. This PR updates the path and also the URL to the new fastlane docs page.

Currently the default way to setup _fastlane_ for ReactNative projects is to set it up in the `ios` or `android` subfolder. This PR updates the path and also the URL to the new fastlane docs page
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels Apr 3, 2017
@ericvicenti

Copy link
Copy Markdown
Contributor

Hmm, I'm not sure why fastlane is in RN's .gitignore file. Shouldn't it be a part of the fastlane installation into a RN app?

@KrauseFx

KrauseFx commented Apr 3, 2017

Copy link
Copy Markdown
Contributor Author

fastlane itself doesn't modify your local .gitignore, but fastlane similarly to CocoaPods is included in all default iOS (Objective C and Swift) .gitignores: https://github.com/github/gitignore/blob/master/Objective-C.gitignore#L31-L56

@shergin shergin added Android and removed Android labels Jun 2, 2017
@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Aug 4, 2017
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@KrauseFx KrauseFx deleted the patch-1 branch August 4, 2017 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants