Skip to content

Remove Windows checks from curses#11241

Merged
Akuli merged 7 commits into
python:mainfrom
rmccampbell:master
Apr 6, 2024
Merged

Remove Windows checks from curses#11241
Akuli merged 7 commits into
python:mainfrom
rmccampbell:master

Conversation

@rmccampbell

Copy link
Copy Markdown
Contributor

Curses is available on Windows through a patch via the windows-curses package. See discussion in #6749.

@github-actions

This comment has been minimized.

@JelleZijlstra

Copy link
Copy Markdown
Member

Could you add some comments explaining the unusual situation here? (#6749 (comment))

@rmccampbell

Copy link
Copy Markdown
Contributor Author

Sure, I already added a comment in _curses.pyi but I'll add one in the top-level module too.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@srittau srittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just blocking merging for now, pending the outcome of the discussion in #6749. I'm not convinced that unconditionally making curses available on Windows in the right course of action.

@Akuli

Akuli commented Mar 24, 2024

Copy link
Copy Markdown
Collaborator

I think we should just fix the conflicts and merge this. After a couple months of no progress, it seems like the "right" thing won't happen any time soon, and it's time to instead go with the practical thing and just give people the autocompletions and type checking they want.

We can always come up with a better solution for specifying platforms later, and add back the if statements if it then makes sense.

@TheStef56

TheStef56 commented Apr 6, 2024

Copy link
Copy Markdown

Why is this pr still open and the check for windows in _curses.pyi if sys.platform != win32 hasn't been removed yet?

@srittau srittau dismissed their stale review April 6, 2024 12:26

Unblocking.

@Akuli

Akuli commented Apr 6, 2024

Copy link
Copy Markdown
Collaborator

This is easiest to review locally by telling git to ignore whitespace:

$ git diff -w origin/main HEAD

@github-actions

github-actions Bot commented Apr 6, 2024

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Akuli Akuli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, and sorry it took us so long :)

@Akuli Akuli merged commit 5e2f741 into python:main Apr 6, 2024
@TheStef56

Copy link
Copy Markdown

Thanks for doing this, and sorry it took us so long :)

Thank you for having listened to us Windows programmers 👍🏻🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants