Fix finding typeshed user install on Windows#3991
Merged
Merged
Conversation
Python 3.5+ installs to %APPDATA%\python\PythonXY. Mypy, when installed as user, installs typeshed to %APPDATA%\python\lib\mypy. This fixes the issues with resolving the path to typeshed. Additionally, more debug information is added to the error message to assist in debugging issues like this in the future.
gvanrossum
reviewed
Sep 23, 2017
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Thanks! Please fix capitalization to "mypy" .
Member
|
Also you have a lint error |
Member
Author
|
I see |
Member
|
Mypy should be used at the start of a sentence, mypy otherwise. |
Member
Author
|
This should also fix #3761. After tests pass it should be ready to merge. |
Member
Author
|
The Appveyor failure is a flake. It has failed every push. |
ilevkivskyi
approved these changes
Sep 24, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.5+ installs to
%APPDATA%\python\PythonXY. Mypy, when installed asuser, installs typeshed to
%APPDATA%\python\lib\mypy. This fixes theissues with resolving the path to typeshed. Additionally, more debug
information is added to the error message to assist in debugging issues
like this in the future.
Fixes #3988