gh-151613: Fix remote debugging frame cache ABA#151614
Open
pablogsal wants to merge 1 commit into
Open
Conversation
pablogsal
force-pushed
the
gh-151613-remote-debugging-frame-cache-aba
branch
from
000eedb to
9f447d8
Compare
pablogsal
requested review from
FFY00,
ZeroIntensity and
ericsnowcurrently
as code owners
pablogsal
force-pushed
the
gh-151613-remote-debugging-frame-cache-aba
branch
2 times, most recently
from
418a947 to
a548b24
Compare
Fixes python#151613. The remote debugging frame cache previously used only the last_profiled_frame address as its cache anchor. If a frame returned and a later frame reused the same _PyInterpreterFrame address, the profiler could accept a stale cache entry and splice parent frames from a different call chain into the current stack. This adds a last_profiled_frame_seq counter next to last_profiled_frame, increments it when the anchor advances, stores it in frame cache entries, and validates cache hits against both the frame address and the sequence. Cache miss walks now copy stack chunks before storing new cache entries so stored continuations come from a stable snapshot. The new regression test exercises alternating call chains and checks that cached stacks never contain frames from both branches.
pablogsal
force-pushed
the
gh-151613-remote-debugging-frame-cache-aba
branch
from
a548b24 to
fc9fafd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151613.
The remote debugging frame cache previously used only the
last_profiled_frameaddress as its cache anchor. If a frame returned and a later frame reused the same_PyInterpreterFrameaddress, the profiler could accept a stale cache entry and splice parent frames from a different call chain into the current stack.This adds a
last_profiled_frame_seqcounter next tolast_profiled_frame, increments it when the anchor advances, stores it in frame cache entries, and validates cache hits against both the frame address and the sequence. Cache miss walks now copy stack chunks before storing new cache entries so stored continuations come from a stable snapshot. The new regression test exercises alternating call chains and checks that cached stacks never contain frames from both branches.