Skip to content

gh-116181: Remove Py_BUILD_CORE_MODULE and Py_BUILD_CORE_MODULE in rotatingtree.c#121260

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
aisk:remove-core-in-rotatingtree
Jul 3, 2024
Merged

gh-116181: Remove Py_BUILD_CORE_MODULE and Py_BUILD_CORE_MODULE in rotatingtree.c#121260
kumaraditya303 merged 1 commit into
python:mainfrom
aisk:remove-core-in-rotatingtree

Conversation

@aisk

@aisk aisk commented Jul 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Since #117511 has been finished and PyMutex is a public API now, we can remove the Py_BUILD_CORE_BUILTIN and Py_BUILD_CORE_MODULE macro define.

@bedevere-app bedevere-app Bot mentioned this pull request Jul 2, 2024
Closed
@aisk aisk requested a review from ericsnowcurrently July 2, 2024 10:41
@aisk aisk added skip news needs backport to 3.13 bugs and security fixes labels Jul 2, 2024
@kumaraditya303 kumaraditya303 merged commit 705a123 into python:main Jul 3, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 3, 2024

Copy link
Copy Markdown

Thanks @aisk for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2024
@aisk @miss-islington
pythongh-116181: Remove Py_BUILD_CORE_BUILTIN and Py_BUILD_CORE_MODUL…
99ac75a 
…E in rotatingtree.c (pythonGH-121260)

(cherry picked from commit 705a123)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Jul 3, 2024

Copy link
Copy Markdown

GH-121307 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 3, 2024
@aisk aisk deleted the remove-core-in-rotatingtree branch July 3, 2024 07:48
kumaraditya303 pushed a commit that referenced this pull request Jul 3, 2024
@miss-islington @aisk
[3.13] gh-116181: Remove Py_BUILD_CORE_BUILTIN and Py_BUILD_CORE_MODU…
8597149 
…LE in rotatingtree.c (GH-121260) (#121307)

gh-116181: Remove Py_BUILD_CORE_BUILTIN and Py_BUILD_CORE_MODULE in rotatingtree.c (GH-121260)
(cherry picked from commit 705a123)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
@vstinner

vstinner commented Jul 3, 2024

Copy link
Copy Markdown
Member

Nice change.

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@aisk @noahbkim
pythongh-116181: Remove Py_BUILD_CORE_BUILTIN and Py_BUILD_CORE_MODUL…
afb0d78 
…E in rotatingtree.c (python#121260)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@aisk @estyxx
pythongh-116181: Remove Py_BUILD_CORE_BUILTIN and Py_BUILD_CORE_MODUL…
afad039 
…E in rotatingtree.c (python#121260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aisk @vstinner @kumaraditya303