reject overlong decimal integer instead of coercing to inf#538
Open
netliomax25-code wants to merge 1 commit into
Open
reject overlong decimal integer instead of coercing to inf#538netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_parse_numberrunsint(sign + clean, base)inside atry/except ValueErrorthat, on failure, falls back tofloat(sign + clean).int()raiseValueError, so the literal is parsed as a float instead. A long run of digits ends up asinf, soa = 9999...(4301+ digits) silently returns a floatinfrather than being rejected as an out-of-range integer.int()cannot parse now returnsNone, so the parser raisesInvalidNumberError. Hex/oct/bin literals (no digit limit) and all valid float literals are unaffected.Repro:
tomlkit.parse("a = " + "9" * 4301)["a"]returns floatinfbefore the change; it raisesInvalidNumberErrorafter. The 4300-digit value still parses as anInteger.Agent Drafting Metadata