Skip to content

chore(Dropdown): convert examples to TypeScript#7388

Merged
tlabaj merged 3 commits into
patternfly:mainfrom
thatblindgeye:dropdown_conversion
May 19, 2022
Merged

chore(Dropdown): convert examples to TypeScript#7388
tlabaj merged 3 commits into
patternfly:mainfrom
thatblindgeye:dropdown_conversion

Conversation

@thatblindgeye

@thatblindgeye thatblindgeye commented May 9, 2022

Copy link
Copy Markdown
Contributor

What: Closes #7383

Dropdown component

I also updated the example for for "Split button (3rd state)" to "Split button (indeterminate state)" since that seems a more appropriate/descriptive name (this state is also mentioned in the when to use switches versus checkboxes section of the Checkbox design guidelines, though the term "intermediate" is used instead).

Additional issues:

@patternfly-build

patternfly-build commented May 9, 2022

Copy link
Copy Markdown
Collaborator

@nicolethoen nicolethoen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The split button action and split button primary action examples are missing a gap between the dropdowns. It's a little confusing because it looks like a single dropdown toggle with a lot of icons/buttons on it.

@thatblindgeye thatblindgeye force-pushed the dropdown_conversion branch from 61179c9 to 5d084d2 Compare May 18, 2022 13:52
@thatblindgeye

Copy link
Copy Markdown
Contributor Author

The split button action and split button primary action examples are missing a gap between the dropdowns. It's a little confusing because it looks like a single dropdown toggle with a lot of icons/buttons on it.

Ah good catch! I added back in the {' '} that the examples originally had which adds that spacing back.

@thatblindgeye thatblindgeye requested a review from jenny-s51 May 18, 2022 13:57

@jenny-s51 jenny-s51 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demos LGTM, nice work Eric !

The checkbox guidelines you linked refer to the 3rd state as an "intermediate" state so we should try to match those!

Added some comments where these occurrences can be updated 🙂

@thatblindgeye

Copy link
Copy Markdown
Contributor Author

@jenny-s51 I had asked Margot about that intermediate vs indeterminate verbiage, and she ended up making an update to the design guidelines for the checkbox to use "indeterminate".

Commit on checkbox guidelines

@jenny-s51 jenny-s51 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Yes, indeterminate definitely makes more sense here. In that case LGTM! 🚀

@tlabaj tlabaj merged commit 5cdecb5 into patternfly:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdown - convert examples to TypeScript

5 participants