Skip to content

fix(CodeIcon): Replace CodeIcon with RhUiCodeIcon#12488

Merged
thatblindgeye merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-code-icon-with-rh-ui-code
Jun 17, 2026
Merged

fix(CodeIcon): Replace CodeIcon with RhUiCodeIcon#12488
thatblindgeye merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-code-icon-with-rh-ui-code

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 16, 2026

Copy link
Copy Markdown
Member

I think we want a microns version but it doesn't exist.

Part of #12401. Breaking into separate PRs so it is easier to review.

Made with Cursor

Summary by CodeRabbit

Release Notes

  • Style
    • Updated icon designs across various components, including data lists, navigation, tables, and editors, for improved visual consistency throughout the application.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 975e0636-68a8-48a6-81bb-89fef9914952

📥 Commits

Reviewing files that changed from the base of the PR and between 7d594f4 and b0eb687.

📒 Files selected for processing (25)
  • packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx
  • packages/react-core/src/demos/Compass/Compass.md
  • packages/react-core/src/demos/Compass/examples/CompassDockDemo.tsx
  • packages/react-core/src/demos/DataList/examples/DataListBasic.tsx
  • packages/react-core/src/demos/DataList/examples/DataListStaticBottomPagination.tsx
  • packages/react-core/src/demos/DataListDemo.md
  • packages/react-core/src/demos/Nav.md
  • packages/react-core/src/demos/Page.md
  • packages/react-core/src/demos/PrimaryDetail.md
  • packages/react-core/src/demos/Tabs.md
  • packages/react-core/src/demos/examples/Nav/NavDockedNav.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
  • packages/react-core/src/demos/examples/Tabs/TabsAndTable.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/TableDemo/TableComposableDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/TableDemo/TableCompoundExpandableDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/TableDemo/TableEditableCompoundExpandableDemo.tsx
  • packages/react-table/src/components/Table/examples/Table.md
  • packages/react-table/src/components/Table/examples/TableCompoundExpandable.tsx
  • packages/react-table/src/demos/Table.md
  • packages/react-table/src/demos/examples/TableCompoundExpansion.tsx
  • packages/react-table/src/demos/examples/TableSortableResponsive.tsx
  • packages/react-table/src/deprecated/components/Table/examples/LegacyTableCompoundExpandable.tsx
  • packages/react-table/src/deprecated/components/Table/examples/Table.md
💤 Files with no reviewable changes (1)
  • packages/react-core/src/demos/Page.md

Walkthrough

All usages of CodeIcon from @patternfly/react-icons are replaced with RhUiCodeIcon across 24 files spanning the react-code-editor, react-core, react-table, and react-integration packages. Changes are limited to import statements and JSX render sites; no component APIs, logic, or layouts are altered.

Changes

CodeIcon → RhUiCodeIcon migration

Layer / File(s) Summary
CodeEditor component icon swap
packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx
Imports RhUiCodeIcon and renders it in both empty-state conditional branches and the language label tab header, replacing the previous CodeIcon.
react-core demo examples and markdown icon swap
packages/react-core/src/demos/Compass/..., packages/react-core/src/demos/DataList/..., packages/react-core/src/demos/Nav.md, packages/react-core/src/demos/Page.md, packages/react-core/src/demos/PrimaryDetail.md, packages/react-core/src/demos/Tabs.md, packages/react-core/src/demos/DataListDemo.md, packages/react-core/src/demos/examples/Nav/NavDockedNav.tsx, packages/react-core/src/demos/examples/PrimaryDetail/..., packages/react-core/src/demos/examples/Tabs/TabsAndTable.tsx
Updates icon imports and all JSX render sites in Compass, DataList, Nav, PrimaryDetail, and Tabs demos and their corresponding markdown documentation files.
react-table examples and demos icon swap
packages/react-table/src/components/Table/examples/Table.md, packages/react-table/src/components/Table/examples/TableCompoundExpandable.tsx, packages/react-table/src/demos/Table.md, packages/react-table/src/demos/examples/TableCompoundExpansion.tsx, packages/react-table/src/demos/examples/TableSortableResponsive.tsx, packages/react-table/src/deprecated/components/Table/examples/...
Replaces CodeIcon with RhUiCodeIcon in the compound expandable, sortable responsive, and legacy deprecated table examples and their markdown documentation.
Integration demo-app table demos icon swap
packages/react-integration/demo-app-ts/src/components/demos/TableDemo/TableComposableDemo.tsx, packages/react-integration/demo-app-ts/src/components/demos/TableDemo/TableCompoundExpandableDemo.tsx, packages/react-integration/demo-app-ts/src/components/demos/TableDemo/TableEditableCompoundExpandableDemo.tsx
Updates icon imports and render sites in the integration demo app's composable, compound expandable, and editable compound expandable table demos.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • patternfly/patternfly-react#12245: Introduced RhUiCodeIcon and the RH-ui icon mapping that this PR adopts as the replacement for CodeIcon across demos and components.

Suggested labels

Needs design review

Suggested reviewers

  • phcox
  • thatblindgeye
  • wise-king-sullyman
  • kmcfaul
  • kaylachumley
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately and concisely describes the main change across all 24 modified files: replacing CodeIcon with RhUiCodeIcon throughout the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rebeccaalpert rebeccaalpert marked this pull request as draft June 16, 2026 20:29
@patternfly-build

patternfly-build commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-code-icon-with-rh-ui-code branch from b7ef391 to b0eb687 Compare June 17, 2026 13:57
@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 17, 2026 13:57
@thatblindgeye thatblindgeye merged commit 9562dbe into patternfly:main Jun 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants