Skip to content

fix(PendingIcon): Replace PendingIcon with RhUiPendingIcon#12459

Merged
rebeccaalpert merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-pending-icon-with-rh-ui-pending
Jun 17, 2026
Merged

fix(PendingIcon): Replace PendingIcon with RhUiPendingIcon#12459
rebeccaalpert merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-pending-icon-with-rh-ui-pending

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 12, 2026

Copy link
Copy Markdown
Member

What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Documentation
    • Updated ProgressStepper examples to use RhUiPendingIcon for the pending step icon instead of the previous pending icon.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 414c1362-614f-4b62-87c7-43337e7dd96a

📥 Commits

Reviewing files that changed from the base of the PR and between 218c11e and 47b9db0.

📒 Files selected for processing (2)
  • packages/react-core/src/components/ProgressStepper/examples/ProgressStepper.md
  • packages/react-core/src/components/ProgressStepper/examples/ProgressStepperCustomIcons.tsx
✅ Files skipped from review due to trivial changes (1)
  • packages/react-core/src/components/ProgressStepper/examples/ProgressStepper.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/react-core/src/components/ProgressStepper/examples/ProgressStepperCustomIcons.tsx

Walkthrough

The ProgressStepper example files are updated to replace the pending icon import and usage with RhUiPendingIcon. Both the Markdown documentation and TypeScript component example are updated to reflect the new icon reference.

Changes

ProgressStepper pending icon examples

Layer / File(s) Summary
Update pending icon references in examples
packages/react-core/src/components/ProgressStepper/examples/ProgressStepper.md, packages/react-core/src/components/ProgressStepper/examples/ProgressStepperCustomIcons.tsx
Icon import statements and icon prop rendering are updated from PendingIcon to RhUiPendingIcon in both the Markdown documentation example and the custom icons component example.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • thatblindgeye
  • nicolethoen
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: replacing PendingIcon with RhUiPendingIcon across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-pending-icon-with-rh-ui-pending branch from 218c11e to 47b9db0 Compare June 17, 2026 17:35
@rebeccaalpert rebeccaalpert merged commit 7637e43 into patternfly:main Jun 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants