Skip to content

fix(LinkIcon): Replace LinkIcon with RhUiLinkIcon#12456

Merged
nicolethoen merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-link-icon-with-rh-ui-link
Jun 17, 2026
Merged

fix(LinkIcon): Replace LinkIcon with RhUiLinkIcon#12456
nicolethoen merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-link-icon-with-rh-ui-link

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 12, 2026

Copy link
Copy Markdown
Member

What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Documentation
    • Updated navigation component example documentation to reflect revised icon usage in the Nav examples.
  • UI Updates
    • Adjusted the navigation icons in example code to use the updated link icon component for the Link 4 item.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4f056ed2-6124-425b-89eb-cb93da4f772b

📥 Commits

Reviewing files that changed from the base of the PR and between a893b4b and 750f4ac.

📒 Files selected for processing (2)
  • packages/react-core/src/components/Nav/examples/Nav.md
  • packages/react-core/src/components/Nav/examples/NavIcons.tsx
✅ Files skipped from review due to trivial changes (2)
  • packages/react-core/src/components/Nav/examples/Nav.md
  • packages/react-core/src/components/Nav/examples/NavIcons.tsx

Walkthrough

The Nav component examples are updated to use RhUiLinkIcon instead of LinkIcon. The import statement is added to the Nav.md documentation, the import in NavIcons.tsx is replaced, and the Link 4 NavItem icon prop is updated to render the new icon.

Changes

Nav example icon update

Layer / File(s) Summary
Update Nav examples to use RhUiLinkIcon
packages/react-core/src/components/Nav/examples/Nav.md, packages/react-core/src/components/Nav/examples/NavIcons.tsx
Nav examples documentation and component are updated to import and render RhUiLinkIcon instead of LinkIcon for the Link 4 NavItem.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • wise-king-sullyman
  • nicolethoen
  • thatblindgeye
  • kmcfaul
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing LinkIcon with RhUiLinkIcon across the updated files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

@thatblindgeye thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a rebase

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-link-icon-with-rh-ui-link branch from a893b4b to 750f4ac Compare June 16, 2026 17:38
@nicolethoen nicolethoen merged commit 8381d72 into patternfly:main Jun 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants