Skip to content

fix(UserIcon): Replace UserIcon with RhUiProfileFillIcon#12452

Merged
nicolethoen merged 2 commits into
patternfly:mainfrom
rebeccaalpert:cursor/replace-user-icon-with-rh-ui-profile-fill
Jun 17, 2026
Merged

fix(UserIcon): Replace UserIcon with RhUiProfileFillIcon#12452
nicolethoen merged 2 commits into
patternfly:mainfrom
rebeccaalpert:cursor/replace-user-icon-with-rh-ui-profile-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 12, 2026

Copy link
Copy Markdown
Member

What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Documentation
    • Updated the Nav examples documentation to use the updated profile icon component.
  • Chores
    • Updated the Alert demo to render the new profile icon as the custom alert icon, keeping the demo visuals consistent with the documentation examples.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 461c7f1d-b354-4db3-b595-23f33ff0a5ff

📥 Commits

Reviewing files that changed from the base of the PR and between a72042e and 96b0619.

⛔ Files ignored due to path filters (2)
  • packages/react-core/src/components/EmptyState/__tests__/Generated/EmptyStateIcon.test.tsx is excluded by !**/generated/**
  • packages/react-core/src/components/EmptyState/__tests__/Generated/__snapshots__/EmptyStateIcon.test.tsx.snap is excluded by !**/*.snap, !**/generated/**
📒 Files selected for processing (2)
  • packages/react-core/src/components/Nav/examples/Nav.md
  • packages/react-integration/demo-app-ts/src/components/demos/AlertDemo/AlertDemo.tsx
✅ Files skipped from review due to trivial changes (1)
  • packages/react-core/src/components/Nav/examples/Nav.md

Walkthrough

This PR replaces the UserIcon import with RhUiProfileFillIcon across examples and demo components. The Nav documentation example and the AlertDemo component are both updated to import and use the new icon.

Changes

Icon Replacement

Layer / File(s) Summary
UserIcon to RhUiProfileFillIcon replacement
packages/react-core/src/components/Nav/examples/Nav.md, packages/react-integration/demo-app-ts/src/components/demos/AlertDemo/AlertDemo.tsx
Icon import and usage are replaced from UserIcon to RhUiProfileFillIcon in Nav.md example documentation and AlertDemo component import and customIcon prop.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

Needs design review

Suggested reviewers

  • kmcfaul
  • thatblindgeye
  • nicolethoen
  • phcox
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: replacing UserIcon with RhUiProfileFillIcon across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-user-icon-with-rh-ui-profile-fill branch from 5bba4db to e47af71 Compare June 12, 2026 18:48
import './nav.css';
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';
import UserIcon from '@patternfly/react-icons/dist/esm/icons/user-icon';
import RhUiProfileFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-profile-fill-icon';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like we're using this icon in any Nav example, could just remove this import entirely

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out; thank you!

@nicolethoen nicolethoen merged commit a1404e3 into patternfly:main Jun 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants