fix(UserIcon): Replace UserIcon with RhUiProfileFillIcon#12452
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis PR replaces the ChangesIcon Replacement
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview: https://pf-react-pr-12452.surge.sh A11y report: https://pf-react-pr-12452-a11y.surge.sh |
a72042e to
5bba4db
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
5bba4db to
e47af71
Compare
| import './nav.css'; | ||
| import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; | ||
| import UserIcon from '@patternfly/react-icons/dist/esm/icons/user-icon'; | ||
| import RhUiProfileFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-profile-fill-icon'; |
There was a problem hiding this comment.
Doesn't seem like we're using this icon in any Nav example, could just remove this import entirely
There was a problem hiding this comment.
Good call out; thank you!
What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.
Additional issues:
Summary by CodeRabbit