Skip to content

fix(Page): pass sidebar state to button for isHamburger#11951

Merged
nicolethoen merged 1 commit into
patternfly:mainfrom
kmcfaul:pagetoggle-expand-console-err
Aug 4, 2025
Merged

fix(Page): pass sidebar state to button for isHamburger#11951
nicolethoen merged 1 commit into
patternfly:mainfrom
kmcfaul:pagetoggle-expand-console-err

Conversation

@kmcfaul

@kmcfaul kmcfaul commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

What: Closes #11949

@patternfly-build

patternfly-build commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator

@jenny-s51 jenny-s51 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmcfaul - LGTM. Console error is no longer logged and nav toggle state works as expected.

@nicolethoen nicolethoen merged commit 60806c2 into patternfly:main Aug 4, 2025
13 checks passed
@patternfly-build

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-code-editor@6.3.1-prerelease.1
  • @patternfly/react-core@6.3.1-prerelease.1
  • @patternfly/react-docs@7.3.1-prerelease.2
  • @patternfly/react-drag-drop@6.3.1-prerelease.1
  • demo-app-ts@6.0.0-prerelease.139
  • @patternfly/react-table@6.3.1-prerelease.2
  • @patternfly/react-templates@6.3.1-prerelease.1

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PageToggleButton - using isHamburgerButton prop logs console error

4 participants