Skip to content

Remove unused Prism CSS files.#2461

Merged
aymen94 merged 1 commit into
nodejs:masterfrom
XhmikosR:master-xmr-rm-unused-prism-css
Sep 18, 2019
Merged

Remove unused Prism CSS files.#2461
aymen94 merged 1 commit into
nodejs:masterfrom
XhmikosR:master-xmr-rm-unused-prism-css

Conversation

@XhmikosR

Copy link
Copy Markdown
Contributor

These aren't used, probably left for historical reasons?

@XhmikosR

XhmikosR commented Sep 10, 2019

Copy link
Copy Markdown
Contributor Author

Can we get this and some of the other CSS PRs moving?

https://github.com/nodejs/nodejs.org/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+author%3AXhmikosR+css

and

https://github.com/nodejs/nodejs.org/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+author%3AXhmikosR+stylus

I'd like to clean up the CSS and finish with the Sass move.

@XhmikosR

Copy link
Copy Markdown
Contributor Author

Ping

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but wouldn't mind a few more sets of eyes to make sure I'm not missing anything. @nodejs/website

@bnb bnb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Served the site locally, everything seemed to work to me. Relatively trivial revert if something is actually broken. :shipit:

@aymen94 aymen94 merged commit 5f63b2c into nodejs:master Sep 18, 2019
@XhmikosR XhmikosR deleted the master-xmr-rm-unused-prism-css branch September 19, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants