Skip to content

tools: update ESLint to 7.21.0#37546

Closed
lpinca wants to merge 0 commit into
nodejs:masterfrom
lpinca:update/eslint
Closed

tools: update ESLint to 7.21.0#37546
lpinca wants to merge 0 commit into
nodejs:masterfrom
lpinca:update/eslint

Conversation

@lpinca

@lpinca lpinca commented Feb 28, 2021

Copy link
Copy Markdown
Member

Update ESLint to version 7.21.0

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 28, 2021
@lpinca lpinca force-pushed the update/eslint branch 2 times, most recently from f9012b9 to fab884e Compare February 28, 2021 07:52

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2021

@jasnell jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

lpinca added a commit to lpinca/node that referenced this pull request Mar 2, 2021
PR-URL: nodejs#37546
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca lpinca closed this Mar 2, 2021
@lpinca

lpinca commented Mar 2, 2021

Copy link
Copy Markdown
Member Author

Landed in 20def25.

@lpinca lpinca deleted the update/eslint branch March 2, 2021 19:41
@lpinca

lpinca commented Mar 2, 2021

Copy link
Copy Markdown
Member Author

It seems I messed up the merge (to get the purple merged status) as the PR shows up as 0 commit PR even though I did not manually close the PR. I hope it is not a problem.

danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37546
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 25, 2021
PR-URL: #37546
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2021
PR-URL: #37546
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #37546
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #37546
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants