Fixes Exceptions and permanent Hang when parsing bad input, Adds bad input tests

[kulgg]

Fixes #196 and #198

[milkshakeuk]

Looks mostly fine, just a few comments, left me know what you think.

[kulgg]

Fixes #198

[milkshakeuk]

@JlKmn did you see some of the other comments?

[kulgg]

@milkshakeuk I think i answered to all of them, what am I missing?

[milkshakeuk]

@JlKmn

#197 (comment)

#197 (comment)

[kulgg]

@milkshakeuk Very strange they didn't show for me on brave and edge. I can hover over the link and see some of the comment but can't click on it. They also don't show for me in Files changed with comments?

[kulgg]

Can you comment them again

[milkshakeuk]

@JlKmn
Looks like I needed to "finish the review" which is why you maybe couldn't see the comments.

[milkshakeuk]

@JlKmn
Okay looks good, the final thing would if I could ask you to rebase your forked master branch from main (NHapi) master branch, currently your master branch is 2 behind and 10 ahead.

[kulgg]

@milkshakeuk should be fine now right?

[github-actions]

Unit Test Results

    5 files    56 suites   8s ⏱️
416 tests 414 ✔️ 2 💤 0 ❌
830 runs  827 ✔️ 3 💤 0 ❌

Results for commit fbde865.

[milkshakeuk]

@JlKmn Yes thanks!

[milkshakeuk]

@JlKmn I have rebased my branch from master so it now includes your changes however now some of my tests are failing because of changes I have made to ParserBase so may need your support to amend those BadInputTests

[kulgg]

@milkshakeuk ok how do we go about that

[milkshakeuk]

@JlKmn Once my PR is ready ill push up a branch which you could fork and have a look at?

[kulgg]

@milkshakeuk ok

[milkshakeuk]

@JlKmn ok here is my branch.

[kulgg]

@milkshakeuk ok i will look at it soon

[kulgg]

@milkshakeuk I looked at it and the changes in exceptions for the tests happen because you rewrote the Parse function in ParserBase.cs that gets called for every BadInput test. One fix would be to extend the one test to accept EncodingNotSupported because it is a HL7 child exception. Maybe move the others to the Gracefully test?
But yeah the Parse function is very different making the tests change behavior

[milkshakeuk]

@JlKmn ok I'll look to make those changes.
Once they are in could you run your fuzzing exercize against the new PipeParser?

[kulgg]

@milkshakeuk Yes

[milkshakeuk]

@JlKmn ok the PR has been merged.

[kulgg]

@milkshakeuk I will do a Fuzzing run on the new Parser tonight, we'll see tomorrow