Add Pascal's Triangle solutions and update lint config#340
Merged
Conversation
✅ Deploy Preview for algorithm-datastructures-math-studies ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📝 WalkthroughWalkthroughこの PR は LeetCode 118「Pascal's Triangle」の日本語/TypeScript ドキュメントと実装例を追加し、サイト索引・生成メタ情報・MarkdownLint 設定を更新します。既存ドキュメントの小さな文言修正も含まれます。 ChangesPascal's Triangle LeetCode Documentation and Portal Update
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Algorithm/Other/leetcode/118`. Pascal's Triangle/claude sonnet 4.6
adaptive/Pascal's_Triangle_Python.md:
- Around line 72-73: Update the table rows labeled "C. 再帰（メモ化なし）" (and the
duplicate entries later) to stop asserting a fixed O(n³) cost; replace the hard
complexity with a phrasing like "非効率（再帰定義に依存し、指数的になることがある）" or "最悪で指数的／再帰定義で変化"
and keep the note about redundant recomputation and recommending `@lru_cache`;
ensure both occurrences (the original and the one referenced as also applies)
are changed for consistency.
In `@Algorithm/Other/leetcode/118`. Pascal's Triangle/claude sonnet 4.6
adaptive/Pascal's_Triangle_Typescript.md:
- Around line 69-70: Update the table row labeled "C. 再帰（メモ化なし）" so the
time-complexity is not asserted as a fixed O(n³); instead state a conditional
expression like "最悪ケースで指数時間（例: O(2^n))、再帰の組み方によっては多項式（例: O(n³)）となる場合がある" and add
a short parenthetical note that complexity depends on recursion structure and
subproblem overlap; apply the same change to the corresponding entries
referenced later in the file.
In `@Algorithm/Other/leetcode/118`. Pascal's Triangle/claude sonnet 4.6
adaptive/README.md:
- Around line 100-101: The README's diagram/invariant and the implementation
disagree about the initial triangle state (implementation starts with triangle =
[] and adds [1] at row_index = 0, while the diagram/invariant start at [[1]]);
make them consistent by choosing one canonical initialization and applying it
everywhere: either change the prose/diagram (“Init”/“Loop” and the invariants at
lines referenced) to reflect starting from an empty triangle and adding [1] at
row_index = 0, or change the implementation description to start with triangle =
[[1]] and set row_index = 1; update the diagram nodes (Init, Loop), the
invariant text, and the two occurrences around lines 245-246 so the variable
names triangle and row_index match the chosen start state.
In `@public/index.html`:
- Line 479: public/index.html was edited directly to add file links (e.g., the
li entries pointing to "Algorithm/Other/leetcode/118. Pascal's Triangle/claude
sonnet 4.6 adaptive/README_React.html") which violates the auto-generation
requirement; revert those manual edits from public/index.html, restore/remove
any missing or altered auto-generation marker, and instead update or create the
generation logic in generate_index.py so those links are produced by running
python generate_index.py; after implementing/repairing generate_index.py, run it
to regenerate public/index.html (confirm the auto-generation marker is present)
and commit only the generator changes, not direct edits to public/index.html.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d9eb4fdc-41db-4487-b0a4-8bd33fcf51d2
📒 Files selected for processing (7)
.markdownlint.jsonAlgorithm/Other/leetcode/118. Pascal's Triangle/claude sonnet 4.6 adaptive/Pascal's_Triangle_Python.mdAlgorithm/Other/leetcode/118. Pascal's Triangle/claude sonnet 4.6 adaptive/Pascal's_Triangle_Typescript.mdAlgorithm/Other/leetcode/118. Pascal's Triangle/claude sonnet 4.6 adaptive/README.mdAlgorithm/Other/leetcode/118. Pascal's Triangle/claude sonnet 4.6 adaptive/README_React.htmlpublic/Algorithm/Other/leetcode/118. Pascal's Triangle/claude sonnet 4.6 adaptive/README_React.htmlpublic/index.html
…zation state; update index generator with auto-gen marker
…dy into dev-from-macmini
…with project rules
myoshi2891
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
主にドキュメントの正確性の向上、プロジェクトの命名規則の統一、およびビルドプロセスの自動化に関連する更新が行われています。
ドキュメントが更新されています。 (66fa8d4)
Markdown ファイル内のリンクや、自動生成される public/index.html も更新されました。 (ca17154)
への自動生成マーカーの追加が行われました。 (fd36a26, 66fa8d4)
コミット一覧: