Skip to content

Fix crash caused by incorrect bounds check (regression in 4.8)#50797

Merged
ahejlsberg merged 2 commits into
mainfrom
fix50479
Sep 16, 2022
Merged

Fix crash caused by incorrect bounds check (regression in 4.8)#50797
ahejlsberg merged 2 commits into
mainfrom
fix50479

Conversation

@ahejlsberg

Copy link
Copy Markdown
Member

Fixes #50479.

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Sep 15, 2022
@ahejlsberg

Copy link
Copy Markdown
Member Author

@andrewbranch @DanielRosenwasser We'll want this one in 4.8.4.

@andrewbranch

Copy link
Copy Markdown
Member

@typescript-bot cherry-pick this to release-4.8

@typescript-bot

typescript-bot commented Sep 16, 2022

Copy link
Copy Markdown
Contributor

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.8 on this PR at 23784d7. You can monitor the build here.

@typescript-bot

Copy link
Copy Markdown
Contributor

Hey @andrewbranch, I've opened #50798 for you.

@ahejlsberg ahejlsberg merged commit 3b84f76 into main Sep 16, 2022
@ahejlsberg ahejlsberg deleted the fix50479 branch September 16, 2022 14:14
@Ayc0

Ayc0 commented Sep 23, 2022

Copy link
Copy Markdown

Thanks for the fix!
Do you know if this will be deployed with the 4.8.4 or if it'll be with the next 4.9.x?

@ahejlsberg

Copy link
Copy Markdown
Member Author

The fix will be in 4.8.4.

@Ayc0

Ayc0 commented Sep 23, 2022

Copy link
Copy Markdown

Thanks 🙏

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getTypeFromTypeNodeWorker crashes with TypeError: Cannot read properties of undefined (reading 'kind')

4 participants