Skip to content

Allow Infinity and NaN to be used as an Enum property identifier#10749

Merged
sandersn merged 3 commits into
microsoft:masterfrom
fabiancook:master
Sep 7, 2016
Merged

Allow Infinity and NaN to be used as an Enum property identifier#10749
sandersn merged 3 commits into
microsoft:masterfrom
fabiancook:master

Conversation

@fabiancook

Copy link
Copy Markdown
Contributor

Fixes #6153

@msftclas

msftclas commented Sep 7, 2016

Copy link
Copy Markdown

Hi @fabiancook, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@sandersn

sandersn commented Sep 7, 2016

Copy link
Copy Markdown
Member

It doesn't look like this works for -Infinity as requested in the bug. Otherwise looks good.

@fabiancook

Copy link
Copy Markdown
Contributor Author

FYI to use -Infinity you will need to enclose it in a string

image

@sandersn

sandersn commented Sep 7, 2016

Copy link
Copy Markdown
Member

To get the Travis build passing, can you merge from master? We had a break when we merged the new transforms code yesterday.

@sandersn

sandersn commented Sep 7, 2016

Copy link
Copy Markdown
Member

Never mind, if you can get it to pass without the merge, don't worry about it.

@fabiancook

Copy link
Copy Markdown
Contributor Author

Looks like its good to go, tried a rebase off master and didn't resolve it, thought I would just try with Travis again, surprised it passes.

@sandersn

sandersn commented Sep 7, 2016

Copy link
Copy Markdown
Member

Me too. But I'll go ahead and merge it. 👍

@sandersn sandersn merged commit 874846a into microsoft:master Sep 7, 2016
@fabiancook

Copy link
Copy Markdown
Contributor Author

Hold up, is this not meant to be just const enum?

@fabiancook

Copy link
Copy Markdown
Contributor Author

Ahh sorry, everything is good

Approved even for non-const enums.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants