Skip to content

TypeScript Issue # 18615.#299

Merged
mhegazy merged 8 commits into
microsoft:masterfrom
muj-beg:TypeScript-Issue-18615
Jan 8, 2018
Merged

TypeScript Issue # 18615.#299
mhegazy merged 8 commits into
microsoft:masterfrom
muj-beg:TypeScript-Issue-18615

Conversation

@muj-beg

@muj-beg muj-beg commented Sep 24, 2017

Copy link
Copy Markdown
Contributor

Added DOMRect, DOMRectReadOnly and DOMRectList types. Modified signatures of properties/methods that used ClientRect or ClintRectList types to use ClientRect | DOMRect or ClintRectList | DOMRectList types respectively. (Left some MS/IE/Edge specific methods/properties unchanged)

@HolgerJeromin

Copy link
Copy Markdown
Contributor

ref microsoft/TypeScript#18615

@mhegazy

mhegazy commented Oct 16, 2017

Copy link
Copy Markdown
Contributor

@muj-beg can you please refresh this PR.

@muj-beg

muj-beg commented Oct 20, 2017

Copy link
Copy Markdown
Contributor Author

@mhegazy PR updated.

@saschanaz

Copy link
Copy Markdown
Contributor

Tip: git pull --rebase Microsoft master is great!

@timocov

timocov commented Nov 1, 2017

Copy link
Copy Markdown
Contributor

@muj-beg why added interfaces is without "flavor": "DOM" property? Seems that is DOM-only types.

# Conflicts:
#	baselines/dom.generated.d.ts
#	inputfiles/addedTypes.json
#	inputfiles/overridingTypes.json
@muj-beg

muj-beg commented Dec 3, 2017

Copy link
Copy Markdown
Contributor Author

@timocov I've added the flavor: DOM to these and merged in latest changes.
(Sorry, my merge history is a mess -- I realize I should have done a rebase. I'll keep that in mind for next time.)

@mhegazy mhegazy closed this Jan 8, 2018
@mhegazy mhegazy reopened this Jan 8, 2018
@mhegazy mhegazy merged commit 945e4c5 into microsoft:master Jan 8, 2018
nscarcella added a commit to nscarcella/TypeScript-DOM-lib-generator that referenced this pull request Sep 29, 2023
@nscarcella nscarcella mentioned this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants