Add Path2D string constructor#277
Closed
thw0rted wants to merge 2 commits into
Closed
Conversation
Author
|
I'm passing the CLA to my management, hopefully it's something they can clear quickly. Sorry for the wait. |
Contributor
|
@thw0rted we will not be able to proceed with this PR without the CLA. |
Author
|
I will bug my management about this again, I had no idea they would take so long getting a response to me. Sorry! |
Contributor
just a reminder you do not need your employers sign off if you do this on your own time. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per microsoft/TypeScript#14660, Path2D should have a constructor overload that takes a single `string. This must be added here to be consistent with the WhatWG Canvas spec, which is a Living Standard.