[0.1] Fix MSRV compatibility#4737
Conversation
8a39057 broke MSRV for 0.1 which is still 1.63. We fix it here.
|
I've assigned @valentinewallace as a reviewer! |
|
No issues found. The diff is identical to my prior review pass. The changes are straightforward MSRV CI dependency pins and a semantically-equivalent |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 0.1 #4737 +/- ##
=======================================
Coverage 84.54% 84.54%
=======================================
Files 137 137
Lines 77617 77617
Branches 77617 77617
=======================================
Hits 65625 65625
+ Misses 9949 9944 -5
- Partials 2043 2048 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
58363d9 to
5b72cd4
Compare
7f7bd9f to
def6a1b
Compare
|
CI still failing |
|
I believe this is correct now. CI is now dependent on itself (its failing to build the release 0.1.10 |
|
Should we go ahead and fix those checks? Otherwise, we're committing to those checks failing on 0.1, etc branches moving forward? |
def6a1b to
3380a42
Compare
|
Both linting and rustfmt have been failing for a while, in the lint case because it targets rustc stable and thus is a moving target. I believe I've fixed the others (except the one that depends on 0.1 itself). |
8a39057 broke MSRV for 0.1 which is still 1.63. We fix it here.