Skip to content

Fix Watch follow parameter detection#2616

Open
tamird wants to merge 1 commit into
kubernetes-client:masterfrom
tamird:tamird/fix-watch-follow-docstring
Open

Fix Watch follow parameter detection#2616
tamird wants to merge 1 commit into
kubernetes-client:masterfrom
tamird:tamird/fix-watch-follow-docstring

Conversation

@tamird

@tamird tamird commented Jun 20, 2026

Copy link
Copy Markdown

What type of PR is this?

/kind bug

What this PR does / why we need it:

OpenAPI-generated methods now document parameter names and types on separate
lines. Watch still looked for the previous combined :param bool follow:
form, so it sent watch=True to pod log methods. Those methods reject the
unexpected keyword instead of streaming logs.

Match the generated :param follow: form and update the existing test fixture
to use the current generated docstring shape.

Which issue(s) this PR fixes:

Fixes #2615

Special notes for your reviewer:

None.

Does this PR introduce a user-facing change?

Fix Watch.stream selecting watch instead of follow when streaming pod logs.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


The generated client now emits parameter names and types on separate
lines. Watch still searches for the old combined line, so it sends
watch=True to pod log methods and the generated client rejects the
unexpected keyword.

Match the current generated format and update the fixture that covers
log streaming.
@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jun 20, 2026
@kubernetes-prow

Copy link
Copy Markdown

Welcome @tamird!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 20, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tamird
Once this PR has been reviewed and has the lgtm label, please assign roycaihw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Watch misclassifies generated pod log methods

1 participant