upgraded openapi generator to v6.6.0 by yliaog · Pull Request #2532 · kubernetes-client/python

yliaog · 2026-03-27T18:17:25Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

upgraded openapi generator to v6.6.0, cleaned up unneeded patches

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Legacy dict(str, str) syntax is no longer supported in in ApiClient deserializer. Only modern dict[str, str] syntax is supported.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

….0, no need to patch

…as the fix already

…turn:

yliaog · 2026-03-28T23:49:19Z

/assign @roycaihw

roycaihw · 2026-03-31T20:53:11Z

        """AdmissionregistrationV1ServiceReference - a model defined in OpenAPI"""  # noqa: E501
        if local_vars_configuration is None:
-            local_vars_configuration = Configuration()
+            local_vars_configuration = Configuration.get_default_copy()


I recall we have something related to default config loading in the past. Does this impact the behavior?

Let's announce this. The upstream change is: OpenAPITools/openapi-generator#8500

added to Breaking change in CHANGELOG

roycaihw · 2026-03-31T20:56:35Z

        """Updates header and query params based on authentication setting.

        :param headers: Header parameters dict to be updated.
-        :param querys: Query parameters tuple list to be updated.


Similar here. Is this a breaking change?

Let's announce this.

added to Breaking change in CHANGELOG

roycaihw · 2026-03-31T20:58:30Z

        :return: The Auth Settings information dict.
        """
        auth = {}
-        if 'authorization' in self.api_key:


Was this a bug?

Let's announce this.

added to Breaking change in CHANGELOG

roycaihw · 2026-03-31T21:40:00Z

Let's also add back the dict[] test (in kubernetes/test/test_api_client.py) as discussed.

roycaihw · 2026-03-31T23:43:26Z

-            # In the python 3, the response.data is bytes.
-            # we need to decode it to string.
-            if six.PY3:
-                r.data = r.data.decode('utf8')


@yliaog Do you know why this was dropped? Could it be related to the str response type cannot be decoded issue you saw?

During your test, could it be that

The api_client.py decoded str once

The rest.py decoded str for a second time, hitting the "cannot be decoded" error.

If that's the case, maybe the correct solution is:

Remove the decode in rest.py (same as what you have in this PR)

Let api_client.py to handle decode for all types.

previously, as you can see in the deleted code here, response.data is bytes, bytes can be decoded to string

after the upgrade to v6.6.0, response.data is str, str cannot be decoded, as discussed here, https://share.google/aimode/t9bV2jOOKREzrlbRm

i think it is correct to drop the code here, as str cannot be decoded. and for the same reason, api_client.py should not try to decode str, in addition to file, and bytes there.

roycaihw · 2026-03-31T23:59:26Z



-WSResponse = collections.namedtuple('WSResponse', ['data'])
+#WSResponse = collections.namedtuple('WSResponse', ['data', 'status', 'getheader'])


Remove this line?

expects it like RESTResponse.

… supports dict syntax

… generator to v6.6.0

…HANGELOG

roycaihw

/lgtm
/approve

k8s-ci-robot · 2026-04-14T20:06:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [roycaihw,yliaog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…-cluster When the scheduler runs in-cluster, kubernetes-python-client v36 changed model constructors to use Configuration.get_default_copy() instead of Configuration() (kubernetes-client/python#2532, OpenAPI Generator v6.6.0). So every V1Pod built after load_incluster_config() captures the global in-cluster Configuration, whose refresh_api_key_hook is a local closure (InClusterConfigLoader._set_config.<locals>._refresh_api_key). pickle cannot serialize a local closure, so putting a task's pod_override V1Pod on the executor's multiprocessing queue raises PicklingError and crashes the scheduler in a loop. This affects any in-cluster KubernetesExecutor deployment where a task sets a V1Pod pod_override, independent of the Airflow version; pinning the client below 36 is not viable because 35.x has a separate no_proxy regression. Reset local_vars_configuration to a fresh Configuration() on the pod_override (recursively) before queuing -- exactly what v35 model constructors produced. It carries no in-cluster auth hook so the pod is picklable, while keeping client_side_validation so the worker-side reconcile_pods setters still work. (Setting it to None instead breaks reconcile: model setters dereference self.local_vars_configuration.client_side_validation.) The pod keeps its V1Pod type through the queue, so run_next is unchanged.

k8s-ci-robot requested a review from roycaihw March 27, 2026 18:21

yliaog force-pushed the master branch 9 times, most recently from 52d4f9f to 48f3727 Compare March 28, 2026 20:30

yliaog added 4 commits March 28, 2026 22:15

removed OPENAPI_GENERATOR_COMMIT, the one in gen repo should be used

4fcc6bb

auto generated by openapi generator v6.6.0

5ef5796

apply rest_client_patch.diff

d1e4a25

removed rest_sni_patch.diff, it is included in openapi generator v6.6…

cbd9e1b

….0, no need to patch

yliaog force-pushed the master branch 2 times, most recently from 5f9ba89 to 59f15fc Compare March 28, 2026 22:40

yliaog added 7 commits March 28, 2026 23:22

apply kubernetes/client/apis hotfix

5e12515

hotfix for patching custom objects issue#866

73bb58c

removed hotfix for Client Context Manager, openapi generator v6.6.0 h…

218e1d2

…as the fix already

removed the two tests temporarily, will add back later

d9abc33

apply hotfix no_proxy support

c5939ff

run scripts/insert_proxy_config.sh

442d737

fixed watch.py, openapi generator v6.6.0 used :rtype: in place of :re…

87bfa84

…turn:

yliaog force-pushed the master branch from 59f15fc to 2dffaad Compare March 28, 2026 23:37

k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 28, 2026

k8s-ci-robot removed the release-note-none Denotes a PR that doesn't merit a release note. label Mar 28, 2026

k8s-ci-robot assigned roycaihw Mar 28, 2026

yliaog force-pushed the master branch from 4cf1c3d to 2dffaad Compare March 29, 2026 00:02

roycaihw reviewed Mar 31, 2026

View reviewed changes

yliaog added 6 commits April 1, 2026 01:39

changed WSResponse to class, added getheader method as api_client

2c5775a

expects it like RESTResponse.

str response type cannot be decoded

54be1a8

removed api_client_dict_syntax.diff, openapi generator v6.6.0 already…

dfa0606

… supports dict syntax

added api_client patch

a8758f3

updated the hotfix for custom client behavior after upgrading openapi…

531fc7d

… generator to v6.6.0

added back the test test_deserialize_dict_syntax_compatibility

d8c380e

yliaog force-pushed the master branch from 720294f to d8c380e Compare April 1, 2026 01:44

added Breaking change from upgrading to openapi generator v6.6.0 to C…

af448c5

…HANGELOG

yliaog force-pushed the master branch from 1aaa759 to af448c5 Compare April 1, 2026 15:47

roycaihw approved these changes Apr 14, 2026

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2026

k8s-ci-robot merged commit bc5e32e into kubernetes-client:master Apr 14, 2026
12 checks passed

penguinolog mentioned this pull request Apr 15, 2026

Bump openapi-generator to v6.6.0 #2499

Closed

vatsrahul1001 mentioned this pull request Jun 22, 2026

KubernetesExecutor scheduler crashes with PicklingError on pod_override with kubernetes client 36.x apache/airflow#68827

Open

2 tasks

vatsrahul1001 mentioned this pull request Jun 22, 2026

Fix KubernetesExecutor scheduler crash when pod_override is queued in-cluster apache/airflow#68819

Closed

1 task



		WSResponse = collections.namedtuple('WSResponse', ['data'])
		#WSResponse = collections.namedtuple('WSResponse', ['data', 'status', 'getheader'])

Conversation

yliaog commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

yliaog commented Mar 28, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

roycaihw commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roycaihw left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Apr 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yliaog commented Mar 27, 2026 •

edited

Loading

roycaihw commented Mar 31, 2026 •

edited

Loading