Improve encryption performance#448
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #448 +/- ##
==========================================
+ Coverage 91.59% 91.62% +0.03%
==========================================
Files 20 20
Lines 2176 2184 +8
Branches 273 273
==========================================
+ Hits 1993 2001 +8
Misses 139 139
Partials 44 44
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every loop would generate a multiple new bytes strings which was quite expensive (more than the encryption itself)
By joining them all together at the end we only have to do it once