Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

AdbCommands.Push(): Added st_mode parameter.#105

Merged
fahhem merged 1 commit into
google:masterfrom
Halastra:push-st-mode
May 3, 2018
Merged

AdbCommands.Push(): Added st_mode parameter.#105
fahhem merged 1 commit into
google:masterfrom
Halastra:push-st-mode

Conversation

@Halastra

@Halastra Halastra commented May 3, 2018

Copy link
Copy Markdown
Contributor

This PR simply exposes the 'st_mode' parameter from FilesyncProtocol.Push() to AdbCommands.Push().
This allows the user to easily upload a file with any desired st_mode.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@coveralls

coveralls commented May 3, 2018

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.06%) to 42.444% when pulling 1022833 on Halastra:push-st-mode into ff48509 on google:master.

@Halastra

Halastra commented May 3, 2018

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@fahhem fahhem merged commit 728714e into google:master May 3, 2018
@fahhem

fahhem commented May 3, 2018

Copy link
Copy Markdown
Contributor

Thanks! Want to add yourself to CONTRIBUTORS?

@Halastra

Halastra commented May 4, 2018

Copy link
Copy Markdown
Contributor Author

Gladly! What do I need to do?

@Halastra Halastra deleted the push-st-mode branch May 4, 2018 07:41
@fahhem

fahhem commented May 4, 2018

Copy link
Copy Markdown
Contributor

Another PR with your name/email in the CONTRIBUTORS file :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants