Skip to content

ref(all): Add support for exactOptionalPropertyTypes flag from TypeScript 4.4#3960

Closed
kamilogorek wants to merge 3 commits into
masterfrom
optional-properties
Closed

ref(all): Add support for exactOptionalPropertyTypes flag from TypeScript 4.4#3960
kamilogorek wants to merge 3 commits into
masterfrom
optional-properties

Conversation

@kamilogorek

Copy link
Copy Markdown
Contributor

Cherry-picked commits from
#3958
#3959

with NodeOptions updated as well.

We might still need/want to update all integrations, handlers, and specific frameworks (NextjsOptions, VueOptions). But it's a good start.

@github-actions

github-actions Bot commented Sep 6, 2021

Copy link
Copy Markdown
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.65 KB (0%)
@sentry/browser - Webpack 22.66 KB (0%)
@sentry/react - Webpack 22.7 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.08 KB (+0.01% 🔺)

@AbhiPrasad

Copy link
Copy Markdown
Contributor

Should we use something like https://github.com/a-tarasyuk/eslint-plugin-redundant-undefined with the followExactOptionalPropertyTypes: true turned on. From what I can see it has support for auto-fixing https://github.com/a-tarasyuk/eslint-plugin-redundant-undefined/blob/9c9b62556f044cb4e3ae9d9e0fe25a4988322eea/src/redundant-undefined.ts#L113

@kamilogorek

Copy link
Copy Markdown
Contributor Author

Oh, that would be much better

@kamilogorek kamilogorek changed the title ref: Add support for exactOptionalPropertyTypes flag from TypeScript 4.4 ref(all): Add support for exactOptionalPropertyTypes flag from TypeScript 4.4 Sep 14, 2021
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@quisido

quisido commented Oct 15, 2021

Copy link
Copy Markdown
Contributor

Is there a status update on this?

@github-actions

github-actions Bot commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@quisido

quisido commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

@lobsterkatie What's the status? 😬

@github-actions

github-actions Bot commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@quisido

quisido commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Does Sentry not have maintainers? The silence isn't a good look... I'd love to get this in.

@AbhiPrasad

Copy link
Copy Markdown
Contributor

Hey, sorry for the delay getting back to this! We kickstarted back up discussion about this internally - we will provide an update soon!

@kamilogorek

Copy link
Copy Markdown
Contributor Author

Opened #4730 instead, as it'll be easier to start it from scratch than rebase over 8mo old PR :P

@kamilogorek kamilogorek deleted the optional-properties branch March 17, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants