Rename beautify command to format#708
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s developer tooling around PHP formatting/linting by renaming the formatting Composer script and simplifying the PHPCS ruleset configuration, with small test-only formatting adjustments to match the updated rules.
Changes:
- Renamed the Composer script from
beautifytoformatand made it runphpcbfin quiet mode. - Simplified
phpcs.xml.distto remove redundant args and explicitly targetflight+tests. - Adjusted anonymous class formatting in a couple of tests to align with the updated PHPCS rules.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
composer.json |
Renames the formatting script to format and updates the command to phpcbf -q. |
phpcs.xml.dist |
Streamlines PHPCS configuration and scopes checks to flight and tests. |
tests/SimplePdoTest.php |
Formatting-only change to anonymous class declaration spacing. |
tests/named-arguments/FlightTest.php |
Formatting-only change to anonymous class declaration spacing. |
Collaborator
|
This is pretty close to a breaking change, but the fix people will have to do is much simpler than the other PR. |
Contributor
Author
|
@n0nag0n why, it affects flight contributors, not flight clients |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project's PHP code formatting and linting configuration, focusing on simplifying and standardizing the code style tools and their settings.
Code formatting and linting configuration:
beautifytoformatand updated it to runphpcbfin quiet mode for automatic code formatting.phpcs.xml.distconfiguration by removing commented-out and redundant arguments, streamlining the rule definitions for PSR1, PSR2, and PSR12, and restricting code checks to theflightandtestsdirectories.