Skip to content

Rename beautify command to format#708

Merged
n0nag0n merged 3 commits into
masterfrom
phpcs-rework
Jun 24, 2026
Merged

Rename beautify command to format#708
n0nag0n merged 3 commits into
masterfrom
phpcs-rework

Conversation

@fadrian06

Copy link
Copy Markdown
Contributor

This pull request updates the project's PHP code formatting and linting configuration, focusing on simplifying and standardizing the code style tools and their settings.

Code formatting and linting configuration:

  • Renamed the Composer script from beautify to format and updated it to run phpcbf in quiet mode for automatic code formatting.
  • Cleaned up the phpcs.xml.dist configuration by removing commented-out and redundant arguments, streamlining the rule definitions for PSR1, PSR2, and PSR12, and restricting code checks to the flight and tests directories.

Copilot AI review requested due to automatic review settings June 23, 2026 16:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s developer tooling around PHP formatting/linting by renaming the formatting Composer script and simplifying the PHPCS ruleset configuration, with small test-only formatting adjustments to match the updated rules.

Changes:

  • Renamed the Composer script from beautify to format and made it run phpcbf in quiet mode.
  • Simplified phpcs.xml.dist to remove redundant args and explicitly target flight + tests.
  • Adjusted anonymous class formatting in a couple of tests to align with the updated PHPCS rules.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
composer.json Renames the formatting script to format and updates the command to phpcbf -q.
phpcs.xml.dist Streamlines PHPCS configuration and scopes checks to flight and tests.
tests/SimplePdoTest.php Formatting-only change to anonymous class declaration spacing.
tests/named-arguments/FlightTest.php Formatting-only change to anonymous class declaration spacing.

Comment thread composer.json
@n0nag0n n0nag0n merged commit 1878648 into master Jun 24, 2026
21 checks passed
@n0nag0n n0nag0n deleted the phpcs-rework branch June 24, 2026 13:38
@n0nag0n

n0nag0n commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

This is pretty close to a breaking change, but the fix people will have to do is much simpler than the other PR.

@fadrian06

Copy link
Copy Markdown
Contributor Author

@n0nag0n why, it affects flight contributors, not flight clients

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants