Simplify code coverage generation#704
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the project’s Composer test-coverage tooling by removing pre-run deletion of clover.xml and consolidating coverage execution into a single, cross-platform test-coverage script.
Changes:
- Removed the redundant
rm -f clover.xmlstep fromtest-coverage. - Removed the Windows-specific
test-coverage:winscript to avoid maintaining duplicate logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes minor updates to the
composer.jsonscripts related to test coverage. The main change is the removal of redundant commands for deleting theclover.xmlcoverage file before running tests, as well as the removal of the Windows-specifictest-coverage:winscript.Test coverage script cleanup:
clover.xmlbefore running thetest-coveragescript, simplifying the process for all environments.test-coverage:winscript, which included Windows-specific commands for deletingclover.xmland running coverage checks, consolidating coverage testing into a single script.