Skip to content

check whether message actually contains units. if not, set units to None#109

Closed
gschramm wants to merge 1 commit into
dtcooper:masterfrom
gschramm:master
Closed

check whether message actually contains units. if not, set units to None#109
gschramm wants to merge 1 commit into
dtcooper:masterfrom
gschramm:master

Conversation

@gschramm

Copy link
Copy Markdown

Fixes #107

The output of the test scripts after my change was:
(base) georg@amun:~/Desktop/python-fitparse/tests$ python test.py
.....................

Ran 21 tests in 29.247s

OK
(base) georg@amun:~/Desktop/python-fitparse/tests$ python test_records.py
..

Ran 2 tests in 0.000s

OK
(base) georg@amun:~/Desktop/python-fitparse/tests$ python test_utils.py
...

Ran 3 tests in 0.001s

@pR0Ps pR0Ps closed this in 059eafe Jul 30, 2020
@pR0Ps

pR0Ps commented Jul 30, 2020

Copy link
Copy Markdown
Collaborator

@gschramm Thanks for your help - I ended up fixing it in a more general way since there were a bunch of other fields that could've had the same issue.

@gschramm

Copy link
Copy Markdown
Author

@pR0Ps Thanks for fixing it! Are you planning a new release soon that people can install from pypi?

@pR0Ps

pR0Ps commented Aug 9, 2020

Copy link
Copy Markdown
Collaborator

@gschramm For sure, I just want to fix a few other small things first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wahoo iOS app generated fit file isse

2 participants