Skip to content

Working Fix For Pattern Lab Lineages When Using Custom Twig Namespaces#21

Closed
sghoweri wants to merge 2 commits into
masterfrom
feature/fix-lineages-w-custom-namespaces
Closed

Working Fix For Pattern Lab Lineages When Using Custom Twig Namespaces#21
sghoweri wants to merge 2 commits into
masterfrom
feature/fix-lineages-w-custom-namespaces

Conversation

@sghoweri

@sghoweri sghoweri commented Oct 1, 2017

Copy link
Copy Markdown
Collaborator

Addresses original issue opened here: EvanLovely/plugin-twig-namespaces#4

Without this workaround when using the Pattern Lab Twig Namespaces plugin using a path / directory other than the one PL would normally assign (ex. one single @mylibrary alias for any pattern to be included by) the original Lineage fix stops working entirely and you get dozens and dozens and dozens of warnings saying you're PL includes / embeds / extends aren't referencing a real pattern.

CC @evanmwillhite @jesconstantine @bradfrost

@sghoweri

sghoweri commented Oct 1, 2017

Copy link
Copy Markdown
Collaborator Author
  • CC @bmuenzenmeyer since these are the sorts of things we'll need to work through in trying to unify the PHP and Node Pattern Lab cores (perhaps bumping this sort of thing to code handling the Twig Engine / adapter)

@sghoweri

sghoweri commented Oct 6, 2017

Copy link
Copy Markdown
Collaborator Author

Closing out - new PR opened pattern-lab#127

@sghoweri sghoweri closed this Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants