Modernize slider#819
Draft
draggie wants to merge 7 commits into
Draft
Conversation
This commit actually reimplements the whole Slider package so that: * Kotlin is being used for Android * Jetpack Compose is used to render the Slider * RNCustomRenderComposeView is implemented as AbstractComposeView didn't work with current solution * SliderViewManagerImpl is removed in favor of keeping everything in ViewManager And most of all: * Slider is now out of @react-native-community
draggie
force-pushed
the
modernize-slider
branch
from
f38bb67 to
2abd25f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes the slider package and example apps across native platforms,
replacing the old native implementations with Swift/SwiftUI on iOS and Kotlin/
Jetpack Compose on Android, while restoring the public slider API and richer
example coverage.
Changes
Migrated Android implementation from Java/native view code to Kotlin +
Jetpack Compose.
Migrated iOS implementation to Swift/SwiftUI with Fabric component wiring.
Rebuilt the example app with a shared two-tab UI: Examples and Props.
Updated mobile and web examples with Callstack branding and new app icons.
Updated example app to newer React Native setup and dependencies.
Refreshed iOS project setup, Podfile/lockfile, app icons, launch screen, and
deployment target.
Updated README prop support/platform notes.
Added .nvmrc and package typings entry.
Removed stale old native implementation files and outdated generated/native
scaffolding.
Windows example/support cleanup is present in the diff but Windows
functionality is not part of this PR’s verification scope.
Test Plan
To Do / Manual Verification
Manually verify Android examples in the app, especially default slider,
min/max, step, value display, disabled, limits, inverted, tint/thumb size,
tap/drag behavior, and step markers.
Manually verify iOS examples for custom tint/image rendering and tap/
drag behavior.
Windows follow-up should be handled separately.