feat(cli): default to port 6565 when no port given for --connect and --listen#15
Merged
Merged
Conversation
…--listen When an address spec contains no port, append the canonical DEFAULT_LISTEN_PORT (6565). Bracketed IPv6 addresses ([::1]) are handled separately — a port is only considered present when `]:` follows the closing bracket, avoiding the false positive from colons in the IPv6 address itself. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
feat(cli): default to port 6565 when no port given for --connect and --listen
Type
feat
Scope
CLI address parsing —
crates/cliOut of scope
Transport, protocol, server config changes
Why
--connect attackerfails with a cryptic format error instead of defaultingto the canonical port.
DEFAULT_LISTEN_PORT(6565) is already used as thedefault for
--listen— apply the same logic to--connect.