Lazy Load RuntimeClient#191
Closed
M-Elsaeed wants to merge 4 commits into
Closed
Conversation
The previous change referenced undefined names (lambda_runtime_api_addr, use_thread_for_polling_next) inside run(), causing a NameError at init and failing all runtime tests. run() already receives a fully constructed lambda_runtime_client argument, so reconstruction is unnecessary and would also clobber the LambdaMultiConcurrentRuntimeClient in the multi-concurrent path. Removing those lines achieves the lazy-load goal (no module-level LambdaRuntimeClient import) and fixes the black formatting failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: -
Description of changes: Lazy Load RuntimeClient
Target (OCI, Managed Runtime, both): both
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.